While I agree with @Evan S. Golar that this AFFECTS the states, that is far different from the claim that it is an unConstitutional law because of state effects. Changes to bankruptcy law (authority given to the feds in Article I, Section 8 ) also affect the states - but that is a power given to the feds by the Constitution.
All the states to be affected could decide to cancel their income tax immediately and instead impose a state sales tax to fund their operations. Or expand their lottery programs. Whatever. That is an area reserved for state control. The high-tax states could be said to have been subsidized by the feds all these years because they allowed state taxes to be deducted, in full, from income (for itemizers). Wasn't that the reason the no-income-tax states fussed until the IRS added state sales taxes in to the mix of what could be deducted? Because it wasn't "fair" to deduct income tax but not sales tax, when a state chose the latter method for raising funds?
As for @Edsel's comments in his first paragraph - I happen to agree. The federal system has been subsidizing both high-income-tax states AND private home ownership. The original intention was to encourage home ownership and relieve some local tax burdens. But as is usual for any government program with social content, no matter how good (and pure) the intent, eventually it has the opposite affect from what was intended. Home ownership, because of the deduction for mortgage interest and property taxes, ultimately made it harder for people to buy, because prices increased. Remember when credit card interest was a deduction? When that went away, people started refinancing their houses to pay off their credit cards (turning short term fun like clothes and trips into thirty-year debt obligations), and we now have the task of teasing apart actual house (purchase or improvement) debt from what was used for the new car or the fancy vacation. Even the charitable deduction - yes it rewards people for being kind (by lowering the cost of so doing) but it also tricks people into thinking that the government should be involved (even obliquely) in a decision to donate to a charity. Hence the year-end "get your deduction!" drives every December.
As for changes to the law in the future - what was it Mark Twain used to say? Something about Congress being in session means we're all in danger.... We can only be certain that the law WILL be changed. All other considerations are up for grabs.